track files included by Core.Compiler #47740
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjkelly
reviewed
Jan 9, 2023
| include(x) = include(Compiler, x) | ||
| function include(mod, path) | ||
| if mod === Compiler | ||
| ccall(:jl_array_grow_end, Cvoid, (Any, UInt), _included_files, UInt(1)) |
There was a problem hiding this comment.
Could use a comment about what this is doing and why?
There was a problem hiding this comment.
this is just a push! before push! is defined.
There was a problem hiding this comment.
I know that. But I'm sayin' for others :)
There was a problem hiding this comment.
Agreed that a comment would be nice. Base.jl should have had one for the same code too.
timholy
approved these changes
Jan 17, 2023
| include(x) = include(Compiler, x) | ||
| function include(mod, path) | ||
| if mod === Compiler | ||
| ccall(:jl_array_grow_end, Cvoid, (Any, UInt), _included_files, UInt(1)) |
There was a problem hiding this comment.
Agreed that a comment would be nice. Base.jl should have had one for the same code too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make
Revisetracking ofCore.Compilermore accurate (timholy/Revise.jl#714). Taking advantage of this will also require a change to Revise.