Avoid redefining documented definitions #14765
Merged
+39
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue mentioned in JuliaLang#14759. Both `multidoc` and `__doc__!` did not take into account the `define` flag which results in them overwriting definitions during base image generation.
|
Thanks. I didn't handle the multidoc case, so we should probably go with this. |
|
Ok, sure. Would you like me to open a pr against jb/overwritten or just merge as is once green? |
|
Let's just merge this when green. |
JeffBezanson
added a commit
that referenced
this pull request
Jan 23, 2016
Avoid redefining documented definitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue mentioned in #14759. Both
multidocand__doc__!did not take into account thedefineflag which results in them overwriting definitions during base image generation.(@JeffBezanson, just noticed after pushing that you've already pushed a fix for this. Feel free to close this / pull this into your branch / merge separately.)