Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@select macro fixes #13853

Closed
wants to merge 2 commits into from
Closed

@select macro fixes #13853

wants to merge 2 commits into from

Conversation

durcan
Copy link

@durcan durcan commented Nov 3, 2015

General:
Syntax change from if/else to =>

Blocking:

  1. moved evaluation of body expression to original parent task.

Non Blocking:

  1. Throw an error if more than one default case
  2. Always check default case last regardless of written position
  3. Allow resulting expression to be anything (previously it had to
    evaluate to a valid rvalue)

General:
Syntax change from if/else to =>

Blocking:
1. moved evaluation of body expression to original parent task.

Non Blocking:
1. Throw an error if more than one default case
2. Always check default case last regardless of written position
3. Allow resulting expression to be anything (previously it had to
evaluate to a valid rvalue)
corresponding update in documentation and tests to reflect the new
select macro syntax
@durcan
Copy link
Author

durcan commented Nov 3, 2015

These are the select macro fixes discussed in issue #13763.

@malmaud malmaud self-assigned this Nov 18, 2015
@brenhinkeller
Copy link
Contributor

It looks like @select has been completely removed sometime in the intervening years, so I'm going to go ahead and assume it's safe to close this (though feel free to reopen if I'm mistaken!)

@vtjnash
Copy link
Member

vtjnash commented Jul 25, 2022

@select was never merged (this was a PR targeting a different PR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants