-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle 7z[.exe]
with libaries/apps
#877
Conversation
Do we need to bundle |
Didn't see any issues complaining about missing Though, as discussed on Slack today, it does not fix the underlying issue of, e.g., MKL_jll being downloaded even if we do not want it. |
Codecov Report
@@ Coverage Diff @@
## master #877 +/- ##
==========================================
+ Coverage 84.26% 84.53% +0.27%
==========================================
Files 3 3
Lines 801 815 +14
==========================================
+ Hits 675 689 +14
Misses 126 126
|
@bgeihe @mashu it would be great if you could test this PR to verify that it fixes your respective issues with |
Sorry, I need to check it again! |
i tested this PR and it works great! fixes JuliaLinearAlgebra/MKL.jl#137 too |
@bjarthur Thanks a lot for verifying! We have conflicting reports from another use (@bgeihe) so I would like to run a few more tests before merging this. However, since for the majority of people this PR seems to work fine, I will create a new release with it probably still within this week. |
Resolves #681.