Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle 7z[.exe] with libaries/apps #877

Merged
merged 8 commits into from
Nov 9, 2023

Conversation

sloede
Copy link
Collaborator

@sloede sloede commented Oct 25, 2023

Resolves #681.

@staticfloat
Copy link
Member

Do we need to bundle lld as well?

@sloede
Copy link
Collaborator Author

sloede commented Oct 25, 2023

Do we need to bundle lld as well?

Didn't see any issues complaining about missing lld, while 7z is required by Pkg, and it's been complained about just today by two separate parties. I thus went ahead and went with the minimum solution that can help to fix this issue.

Though, as discussed on Slack today, it does not fix the underlying issue of, e.g., MKL_jll being downloaded even if we do not want it.

src/PackageCompiler.jl Outdated Show resolved Hide resolved
src/PackageCompiler.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #877 (025ce85) into master (254c988) will increase coverage by 0.27%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #877      +/-   ##
==========================================
+ Coverage   84.26%   84.53%   +0.27%     
==========================================
  Files           3        3              
  Lines         801      815      +14     
==========================================
+ Hits          675      689      +14     
  Misses        126      126              
Files Coverage Δ
src/PackageCompiler.jl 92.72% <100.00%> (+0.15%) ⬆️

@sloede
Copy link
Collaborator Author

sloede commented Oct 26, 2023

@bgeihe @mashu it would be great if you could test this PR to verify that it fixes your respective issues with 7z not being found by Pkg.

src/PackageCompiler.jl Outdated Show resolved Hide resolved
@benegee
Copy link

benegee commented Oct 26, 2023

Works for me. Praise @sloede !

Sorry, I need to check it again!

@bjarthur
Copy link

bjarthur commented Nov 1, 2023

i tested this PR and it works great! fixes JuliaLinearAlgebra/MKL.jl#137 too

@sloede
Copy link
Collaborator Author

sloede commented Nov 2, 2023

@bjarthur Thanks a lot for verifying! We have conflicting reports from another use (@bgeihe) so I would like to run a few more tests before merging this. However, since for the majority of people this PR seems to work fine, I will create a new release with it probably still within this week.

@sloede sloede merged commit 47ea73a into JuliaLang:master Nov 9, 2023
24 of 45 checks passed
@sloede sloede deleted the msl/bundle-libexec branch November 9, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7z.exe and 7z.dll are not included as dependencies on the bin folder of a compiled package.
5 participants