-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
major refactoring of conversion related code #175
Conversation
7aae989
to
1f0d6e1
Compare
If support for |
I meant support |
Then I don't understand why you wrote that. :-) |
fixup fixup2
with a lot of refactorings
1f0d6e1
to
53f8f6e
Compare
because I made a stupid typo... |
* pull-request-163: Support Nullable Date/DateTime Convert Date and DateTime to/from R # Conflicts: # src/convert-default.jl # src/convert/base.jl
53f8f6e
to
07397dc
Compare
with a lot of other improvements
07397dc
to
e0a6859
Compare
1809023
to
f15c093
Compare
Will merge soon if there are no other comments. cc: @simonbyrne @dmbates |
CategoricalArrays 0.0.6 | ||
NullableArrays 0.1.0 | ||
CategoricalArrays 0.1.0 | ||
AxisArrays 0.0.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you've decided to use AxisArrays rather than NamedArrays? I'm still unsure what's the best approach (e.g. for my package FreqTables). The generality of AxisArray
(numeric and categorical axes) is appealing, but the goal of the package does not seem to completely match the R approach to array names. In particular, the printing of names before the data (rather than on each line as in R/NamedArrays) isn't practical for categorical axes.
@mbauman What do you think about this? Are the goals compatible? Could the printing evolve towards what NamedArrays does? i.e. something like this:
4×4 Named Array{Int64,2}
Dim1 ╲ Dim2 │ A B C D
────────────┼───────────────
a │ 30 20 30 20
b │ 30 20 30 20
c │ 20 30 20 30
d │ 20 30 20 30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd absolutely like to see better printing of AxisArrays. It's still a young project in terms of the number of hours that have been dedicated to it.
I'm not familiar with any homogenous named array in R, so I'm not entirely sure about the use-case, but the goal of AxisArrays is to provide core support for many disparate domains. Then secondary packages can layer on more domain-specific behaviors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
R named arrays don't have anything really specific. Names are always strings, indexing by name is supported (but only by putting the index in the position corresponding to the dimension). Names are propagated by some operations like element-wise ops and reductions (which isn't supported by AxisArrays yet IIRC). The way they are printed is similar to the NamedArray
example above. I was afraid the way AxisArrays
are printed was a design decision, but if you would be OK with something more like NamedArray
it would be great.
(Then I'm not a fan of a name, I wouldn't have considered dimension names as axes, but I guess that's a minor point. :-)
Since the conversion to AxisArrays has to be explicit, i.e. |
support DataTableDataTables doesn't play well with DataFrames Overwrites DataFrames describe function JuliaData/DataTables.jl#33
Though DataTables support is ready to merge, it was removed from the current PR at 50b1e80
and will be merged in the future.
issue subsetting a StrSxp Issues related to subsetting a VectorListSxp, particularly, a StrSxp #86(not sure what the best practice is, won't fix now)towards #138