Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add complex fill value decoding #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xzackli
Copy link

@xzackli xzackli commented Oct 8, 2024

Complex arrays can end up specifying a fill value of Any[0.0, 0.0], which needs to be converted into the appropriate complex number.

@asinghvi17
Copy link
Member

Thanks, could you add a test for this?

@meggart
Copy link
Collaborator

meggart commented Dec 6, 2024

I agree, a small test, ideally one that includes some python interoperability would be highly appreciated

@lazarusA
Copy link

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants