Make mark consistent with skip and IOBuffer
#201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhz2
commented
Mar 31, 2024
| ok &= eof(stream) | ||
| ok &= isreadable(stream) | ||
| close(stream) | ||
| end | ||
| # read without stop_on_end should read the full data. |
There was a problem hiding this comment.
This test isn't related to this PR but was something I noticed wasn't covered by current tests.
nhz2
commented
Mar 31, 2024
| checkmode(stream) | ||
| return mark!(stream.buffer1) | ||
| function Base.mark(stream::TranscodingStream)::Int64 | ||
| ready_to_read!(stream) |
There was a problem hiding this comment.
This throws an error if mark is used on a stream in write, close, or panic modes.
nhz2
commented
Mar 31, 2024
| if mode === :read || mode === :stop | ||
| while !eof(stream) && buffersize(buffer1) < offset - skipped | ||
| n = buffersize(buffer1) | ||
| emptybuffer!(buffer1) |
There was a problem hiding this comment.
The use of emptybuffer! here was discarding potentially marked data.
nhz2
commented
Mar 31, 2024
| skipbuffer!(buffer1, offset - skipped) | ||
| end | ||
| else | ||
| # TODO: support skip in write mode |
There was a problem hiding this comment.
I'm not sure what this TODO means, but I add a docstring to clarify that skip behaves like a read that ignores eof and discards the read bytes.
There was a problem hiding this comment.
I also moved the skip to be near the other read functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.