New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow non 1-based arrays in `readbytes!` #200

Merged

nhz2 merged 2 commits into master from nz/non-one-based-arrays

Jun 24, 2024

Member

nhz2 commented Mar 30, 2024 •

edited

Loading

This PR changes a hardcoded 1 to firstindex in the readbytes! function.

I can't test this with OffsetArrays.jl because an OffsetArray isn't a DenseArray

nhz2 added 2 commits

March 30, 2024 15:57


          use firstindex instead of 1

9dea17d


          remove Int64

dca1ce1

nhz2 marked this pull request as ready for review

March 30, 2024 20:15

nhz2 merged commit 2a7af65 into master

23 checks passed

nhz2 deleted the nz/non-one-based-arrays branch

June 24, 2024 01:55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet