Fix stop_on_end = true
closing underlying stream
#178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #85 #95 #117 #128
This PR ensures the underlying stream is not closed if
stop_on_end = true
is used.This PR removes the done mode added in #177. With this PR when a
stop_on_end = true
stream reaches the end of a data chunk while writing, instead of going into stop or done mode the stream will restart the codec and concatenate the next data chunk, like it would ifstop_on_end = false
. After writing,stop_on_end = true
only prevents the underlying stream from being closed.These changes might be slightly breaking but only affect streams created with
stop_on_end = true
and in write mode.