Use LazyRead instead of read_bytes #185
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When reading
andora.osm.pbf
with OpenStreetMapX (using pszufe/OpenStreetMapX.jl#52), the timing is:Before this PR:
After this PR:
read_bytes
makes a copy of the bytes, even nested ones if an object contains another object or a packed vector, ...With this PR, we make instead a wrapper type that virtually limits the size of the
IO
.As this can be called recursively, this could create a stack of
LazyRead
wrappers so we take care of avoiding this and just update theLazyRead
instead.