Merge pull request #29 from staticfloat/sf/fix_ambiguity

Fix `SymbolRef()` ambiguity on 32-bit platforms
JuliaIO · Dec 16, 2020 · 7797652 · 7797652
2 parents c076117 + b55aabf
commit 7797652
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Abstract/Symbol.jl b/src/Abstract/Symbol.jl
@@ -183,7 +183,7 @@ SymbolRef(symbols::Symbols, sym::SymtabEntry, idx::UInt32)
 Construct a `SymbolRef` object pointing to the given `SymtabEntry`, which
 itself represents the `idx`'th symbol within the given `Symbols` collection.
 """
-@mustimplement SymbolRef(symbols::Symbols, sym::SymtabEntry, idx::UInt32)
+@mustimplement SymbolRef(symbols::Symbols, sym::SymtabEntry, idx)
 @mustimplement deref(sym::SymbolRef)
 
 """
@@ -240,4 +240,4 @@ function show(io::IO, sym::Union{SymtabEntry{H},SymbolRef{H}}) where {H <: Objec
     end
 end
 
-show(io::IO, syms::Symbols{H}) where {H <: ObjectHandle} = show_collection(io, syms, H)
+show(io::IO, syms::Symbols{H}) where {H <: ObjectHandle} = show_collection(io, syms, H)
diff --git a/src/ELF/ELFSymbol.jl b/src/ELF/ELFSymbol.jl
@@ -175,4 +175,4 @@ function symbol_value(sym::ELFSymbolRef)
 
     # Return our ill-gotten goods
     return value
-end
+end
-Original file line number
+Diff line change
@@ Expand Up / @@ -175,4 +175,4 @@ function symbol_value(sym::ELFSymbolRef) @@
         # Return our ill-gotten goods
         return value
-    end
+    end