-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use BinaryProvider for binaries #85
Conversation
This avoids worrying about any potential version oddities with libxml2 installed on the system, and it means we don't have to blindly assume that it's available everywhere but Windows.
5c3f4de
to
18a1273
Compare
Can you make this just the BinaryProvider change and hold off on using Appveyor.jl for a separate PR? It's doing some things it shouldn't be doing. |
18a1273
to
8dceba9
Compare
8dceba9
to
052ef32
Compare
Sure thing. I've changed the second commit to just add 0.7 lines to the Travis and AppVeyor configs. |
This fixes a couple of open issues, it passes all tests, and is blocking some time-sensitive work elsewhere, so I'm going to go ahead and merge. |
What does it fix exactly? And what other work depends on it? Please be more specific. |
Part of this is that the package depends on a feature which was deleted for no good reason and against objections upstream. That never got fixed where it should have been dealt with? |
Internal AWS stuff.
Which is that? |
See linked issues |
soname handling in ccall / dlopen - that's the only reason this wouldn't work on 0.7 as-is, I believe |
Oh, that. 😆 Yeah. Luckily this also fixes the issue, since the Another 0.7 issue is that WinRPM doesn't work, and there's currently no way to specify platform-specific dependencies with Pkg3, so |
Is JuliaLang/Pkg.jl#165 realistically going to happen in some way? WinRPM shouldn't be that far from working on 0.7, at least on Windows. |
It's slated for inclusion in 0.7.0-rc1, so hopefully? |
This uses the same builder as EzXML.
Fixes #56
Fixes #84