Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use BinaryProvider for binaries #85

Merged
merged 2 commits into from
Jul 26, 2018
Merged

Use BinaryProvider for binaries #85

merged 2 commits into from
Jul 26, 2018

Conversation

ararslan
Copy link
Member

@ararslan ararslan commented Jul 26, 2018

This uses the same builder as EzXML.

Fixes #56
Fixes #84

This avoids worrying about any potential version oddities with libxml2
installed on the system, and it means we don't have to blindly assume
that it's available everywhere but Windows.
@ararslan ararslan force-pushed the aa/binaryprovider branch from 5c3f4de to 18a1273 Compare July 26, 2018 02:11
@tkelman
Copy link
Contributor

tkelman commented Jul 26, 2018

Can you make this just the BinaryProvider change and hold off on using Appveyor.jl for a separate PR? It's doing some things it shouldn't be doing.

@ararslan ararslan force-pushed the aa/binaryprovider branch from 18a1273 to 8dceba9 Compare July 26, 2018 16:56
@ararslan ararslan force-pushed the aa/binaryprovider branch from 8dceba9 to 052ef32 Compare July 26, 2018 16:57
@ararslan
Copy link
Member Author

Sure thing. I've changed the second commit to just add 0.7 lines to the Travis and AppVeyor configs.

@ararslan
Copy link
Member Author

This fixes a couple of open issues, it passes all tests, and is blocking some time-sensitive work elsewhere, so I'm going to go ahead and merge.

@ararslan ararslan merged commit ffd0b77 into master Jul 26, 2018
@ararslan ararslan deleted the aa/binaryprovider branch July 26, 2018 18:29
@tkelman
Copy link
Contributor

tkelman commented Jul 26, 2018

What does it fix exactly? And what other work depends on it? Please be more specific.

@tkelman
Copy link
Contributor

tkelman commented Jul 26, 2018

Part of this is that the package depends on a feature which was deleted for no good reason and against objections upstream. That never got fixed where it should have been dealt with?

@ararslan
Copy link
Member Author

And what other work depends on it?

Internal AWS stuff.

the package depends on a feature which was deleted for no good reason and against objections upstream

Which is that?

@ararslan
Copy link
Member Author

What does it fix exactly?

See linked issues

@tkelman
Copy link
Contributor

tkelman commented Jul 26, 2018

soname handling in ccall / dlopen - that's the only reason this wouldn't work on 0.7 as-is, I believe

@ararslan
Copy link
Member Author

Oh, that. 😆 Yeah. Luckily this also fixes the issue, since the libxml2 constant defined by BinaryProvider points to the fully qualified and versioned library, so we don't need to rely on internal mapping.

Another 0.7 issue is that WinRPM doesn't work, and there's currently no way to specify platform-specific dependencies with Pkg3, so Pkg.build("WinRPM") runs and fails on every platform.

@tkelman
Copy link
Contributor

tkelman commented Jul 26, 2018

there's currently no way to specify platform-specific dependencies with Pkg3

Is JuliaLang/Pkg.jl#165 realistically going to happen in some way? WinRPM shouldn't be that far from working on 0.7, at least on Windows.

@ararslan
Copy link
Member Author

It's slated for inclusion in 0.7.0-rc1, so hopefully?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants