WIP: Initial attempt at adding IO jlread and jlwrite functions. #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
- Coverage 89.83% 87.79% -2.04%
==========================================
Files 21 22 +1
Lines 2411 2467 +56
==========================================
Hits 2166 2166
- Misses 245 301 +56
Continue to review full report at Codecov.
|
rofinn
commented
Oct 30, 2020
| return result | ||
| end | ||
|
|
||
| function jlwrite(io::IO, data::AbstractDict) |
There was a problem hiding this comment.
This function currently only works correctly with IOStream. I feel like the core logic of JLD2 is geared too heavily for file io streams for this to be a useful PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figured this probably belongs in JLD2 rather than JLSO. I'm currently stuck on an issue where I can't figure out why writing the objects doesn't put the buffer position at the same place as when reading. Based off an initial example here https://gist.github.com/JonasIsensee/53ad332fd32af92691b40d17a640ead3. Related JLSO issue invenia/JLSO.jl#68