Skip to content

Commit

Permalink
Merge pull request #569 from Octogonapus/dont_hide_exceptions
Browse files Browse the repository at this point in the history
Don't hide exception data during loading and saving
  • Loading branch information
JonasIsensee authored Jul 15, 2024
2 parents 500cbd1 + 7940a7a commit 41cf9dd
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 10 deletions.
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,7 @@
*.jld
/test/test_out.jld

docs/build/
docs/build/

Manifest.toml
.vscode/
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name = "JLD2"
uuid = "033835bb-8acc-5ee8-8aae-3f567f8a3819"
version = "0.4.49"
version = "0.4.50"

[deps]
FileIO = "5789e2e9-d7fb-5bc7-8068-2c6fae9b9549"
Expand Down
6 changes: 0 additions & 6 deletions src/fileio.jl
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,6 @@ function fileio_load(f::File{format"JLD2"}; nested::Bool=false, kwargs...)
else
return loadtodict!(Dict{String,Any}(), file)
end
catch e
throw(e)
finally
close(file)
end
Expand All @@ -54,8 +52,6 @@ function fileio_load(f::File{format"JLD2"}, varname::AbstractString; kwargs...)
file = jldopen(FileIO.filename(f), "r"; kwargs...)
try
return load_data_or_dict(file, varname)
catch e
throw(e)
finally
close(file)
end
Expand All @@ -68,8 +64,6 @@ function fileio_load(f::File{format"JLD2"}, varnames::Tuple{Vararg{AbstractStrin
file = jldopen(FileIO.filename(f), "r"; kwargs...)
try
return map(var -> load_data_or_dict(file, var), varnames)
catch e
throw(e)
finally
close(file)
end
Expand Down
2 changes: 0 additions & 2 deletions src/loadsave.jl
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,6 @@ function jldsave(filename::AbstractString, compress=false, iotype::Union{Type{IO
for (k,v) in pairs(kwargs)
write(f, string(k), v, wsession)
end
catch e
throw(e)
finally
close(f)
end
Expand Down

2 comments on commit 41cf9dd

@JonasIsensee
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/111117

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.4.50 -m "<description of version>" 41cf9dd603d02897d1c8c7d4c44b64e5b3e4d1e9
git push origin v0.4.50

Please sign in to comment.