An assortment of minor changes #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really nice |
musm
approved these changes
Oct 7, 2020
musm
reviewed
Oct 7, 2020
| @@ -283,7 +283,7 @@ end | |||
| convert(::Type{hid_t}, attr::Attribute) = attr.id | |||
| show(io::IO, attr::Attribute) = isvalid(attr) ? print(io, "HDF5 attribute: ", name(attr)) : print(io, "HDF5 attribute (invalid)") | |||
|
|
|||
| mutable struct Attributes | |||
There was a problem hiding this comment.
Is this the only mutable struct -> struct audited?
There was a problem hiding this comment.
I didn't check thoroughly — I noticed it while browsing through your rename PR and this one was the only one that stood out to me as not needing to be mutable since it doesn't add a finalizer.
There was a problem hiding this comment.
It looks like the only candidate, though:
$ git grep 'mutable struct'
src/HDF5.jl:mutable struct File <: DataFile
src/HDF5.jl:mutable struct Group <: DataFile
src/HDF5.jl:mutable struct Properties
src/HDF5.jl:mutable struct Dataset
src/HDF5.jl:mutable struct Datatype
src/HDF5.jl:mutable struct Dataspace
src/HDF5.jl:mutable struct Attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a collection of small changes I've been collecting. Notable things include:
showmethod itself. I've also added a "fast path" that avoids the hack if the datatype is recognized as valid. (Unfortunately it's not likely to be taken often since most results probably give the built-in types, but it's something.)Float16#341 just sitting there without resolution — here I've added the low-level methods that it was adding to be used.reinterpretwithin_dataspaceactually creates aReinterpretArrayon modern Julia versions rather than anArray(but apparently that's not an issue when passed down to C). The broadcast expression is also just easier to read.