Skip to content

Commit

Permalink
mark broken tests
Browse files Browse the repository at this point in the history
  • Loading branch information
nhz2 committed Oct 26, 2024
1 parent ffcff8c commit d4eda46
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 15 deletions.
1 change: 0 additions & 1 deletion .github/workflows/Downstream.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ jobs:
- "Genie"
- "PPTX"
- "Serde"
- "TimeZones"
- "XLSX"
steps:
- uses: actions/checkout@v4
Expand Down
8 changes: 0 additions & 8 deletions Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,3 @@ XML2_jll = "02c8fc9c-b97f-50b9-bbe4-9be30ff0a78a"
Printf = "1.3"
XML2_jll = "2.9"
julia = "1.6"

[extras]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
Logging = "56ddb016-857b-54e1-b83d-db4d58db5568"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Aqua", "Test", "Logging"]
5 changes: 5 additions & 0 deletions test/Project.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
[deps]
Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
EzXML = "8f5d6c58-4d21-5cfd-889c-e3ad7ee6a615"
Logging = "56ddb016-857b-54e1-b83d-db4d58db5568"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
13 changes: 7 additions & 6 deletions test/runtests.jl
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
using EzXML
using Test
using Logging: SimpleLogger, with_logger
using Aqua: Aqua

Aqua.test_all(EzXML; ambiguities=false)

# Capture logging messages using a local logger.
function capture_logging_messages(proc)
Expand Down Expand Up @@ -183,7 +186,7 @@ end
_, messages = capture_logging_messages() do
@test_throws EzXML.XMLError parsexml("<gepa?>jgo<<<><<")
end
@test occursin("caught 4 errors; throwing the first one", messages)
@test occursin("errors; throwing the first one", messages)
end

@testset "HTML" begin
Expand Down Expand Up @@ -372,8 +375,9 @@ end
@test reader.content == "Hey"
@test reader.namespace == "http://www.w3.org/1999/xhtml"
elseif reader.:type == EzXML.READER_END_ELEMENT
@test !hasnodecontent(reader)
@test reader.content === nothing
# This is broken in XML2_jll 2.13.4 but works in 2.12.7
@test_broken !hasnodecontent(reader)
@test_broken reader.content === nothing
end
end
@test "head" names
Expand Down Expand Up @@ -1462,6 +1466,3 @@ if "stress" in ARGS
swap_xml()
end

using Aqua

Aqua.test_all(EzXML; ambiguities=false)

0 comments on commit d4eda46

Please sign in to comment.