Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw DimensionMismatch for broadcast on mixed dimensions #43

Closed
wants to merge 1 commit into from
Closed

throw DimensionMismatch for broadcast on mixed dimensions #43

wants to merge 1 commit into from

Conversation

rafaqz
Copy link
Collaborator

@rafaqz rafaqz commented Aug 28, 2021

This is a stop-gap measure while #41 is broken. It shouldn't be possible to broadcast with an object of different dimensionality and silently get the wrong answer.

@rafaqz rafaqz requested a review from meggart August 28, 2021 20:37
@rafaqz
Copy link
Collaborator Author

rafaqz commented Aug 28, 2021 •
edited
Loading

Eh seems broadcast doesn't even work for non-chunked arrays that are the right size. This was just a big in Array/collect.

@rafaqz rafaqz closed this Sep 17, 2021
@rafaqz rafaqz deleted the rs/error_on_dimension_mismatch branch April 18, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meggart meggart Awaiting requested review from meggart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rafaqz