remove dead code

JuliaIO · Oct 6, 2024 · 0e13c10 · 0e13c10
1 parent 2a5b290
commit 0e13c10
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 8 deletions.
diff --git a/src/compression.jl b/src/compression.jl
@@ -101,13 +101,8 @@ function TranscodingStreams.startproc(codec::ZstdCompressor, mode::Symbol, error
             return :error
         end
     end
-    code = reset!(codec.cstream)
-    if iserror(code)
-        error[] = ErrorException("zstd error resetting compression context")
-        :error
-    else
-        :ok
-    end
+    reset!(codec.cstream)
+    return :ok
 end
 
 if isdefined(TranscodingStreams, :pledgeinsize)

diff --git a/src/libzstd.jl b/src/libzstd.jl
@@ -60,7 +60,11 @@ function reset!(cstream::CStream)
     res = LibZstd.ZSTD_CCtx_reset(cstream, LibZstd.ZSTD_reset_session_only)
     reset!(cstream.ibuffer)
     reset!(cstream.obuffer)
-    return res
+    if iserror(res)
+        # According to zstd.h "Resetting session never fails" so this branch should be unreachable.
+        error("unreachable")
+    end
+    return
 end
 
 """