Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a finalizer to prevent memory leaks #42

Closed
wants to merge 2 commits into from
Closed

Add a finalizer to prevent memory leaks #42

wants to merge 2 commits into from

Conversation

nhz2
Copy link
Member

@nhz2 nhz2 commented Dec 17, 2024

Fixes #27

This PR uses atomic operations to prevent multiple finalizers from freeing the same stream concurrently.

This requires julia 1.7

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 87.15%. Comparing base (95a9fc8) to head (01df96f).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/compression.jl 77.77% 10 Missing ⚠️
src/decompression.jl 82.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
+ Coverage   82.63%   87.15%   +4.51%     
==========================================
  Files           4        4              
  Lines         167      179      +12     
==========================================
+ Hits          138      156      +18     
+ Misses         29       23       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak if decompressed stream is not explicitly closed
1 participant