Allow to specify module for resolving names #28
Conversation
timotaularson
changed the title
timotaularson
changed the title
|
bump. If this solves the problem, shouldn't it be merged? |
|
I am pretty new to Julia and Git and Github and PR’s…
so if there are things I should do different or improve on the PR please let me know.
The PR works for my uses, but I don’t know if it is how MikeInnes wants to approach it.
|
|
|
||
| parse(io::IO) = backrefs!(parse_doc(io)) | ||
| parse(path::String) = open(parse, path) | ||
|
|
||
| load(x) = raise_recursive(parse(x)) | ||
| load(x, init=Main) = raise_recursive(parse(x), init) |
|
1 year has passed since the pull request. Maybe this repository should be cloned and made as new, forked project? (If its so dead now) |
|
@CarloLucibello @DhairyaLGandhi Can we merge this? It is blocking pre-trained weights from being used in Metalhead without the user loading Zygote in the REPL. |
|
yes this would be great to have. Maybe that review comment about a possible switch to Also, having tests would be nice if someone is willing to provide them, otherwise, this should not block the much more important work for Metalhead. |
|
@timotaularson Sorry for the long delay. Do you mind adding the tests? Or I can take over and re-submit this PR, but I always like to preserve authorship for the people who take the effort to contribute. |
|
Thank you for looking at this. I am very busy right now, and would be
grateful if you could add tests, do the suggested rename, etc. as you see
fit.
…--Tim
On Mon, Mar 1, 2021, 9:34 PM Kyle Daruwalla ***@***.***> wrote:
@timotaularson <https://github.com/timotaularson> Sorry for the long
delay. Do you mind adding the tests? Or I can take over and re-submit this
PR, but I always like to preserve authorship for the people who take the
effort to contribute.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#28 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKRBP5FHF7DMRCGRMAIUSX3TBRFDRANCNFSM4GYYKJWA>
.
|
|
Closed by #91 |
Add optional parameter to BSON.load function to specify module for resolving names.
Solves #25 other than not updating the @load macro.