Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nightly CI and fix invalid Metal API usage #448

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Conversation

christiangnrd
Copy link
Contributor

@christiangnrd christiangnrd commented Oct 4, 2024

No need to run nightly when we know it'll fail considering the current Apple silicon runner situation

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metal Benchmarks

Benchmark suite Current: c0d2718 Previous: ff7c7eb Ratio
private array/construct 26576.333333333332 ns 26687.5 ns 1.00
private array/broadcast 457916.5 ns 465979.5 ns 0.98
private array/random/randn/Float32 1007000 ns 993270.5 ns 1.01
private array/random/randn!/Float32 624854.5 ns 632166.5 ns 0.99
private array/random/rand!/Int64 575687.5 ns 568500 ns 1.01
private array/random/rand!/Float32 586625 ns 583500 ns 1.01
private array/random/rand/Int64 885396 ns 880458 ns 1.01
private array/random/rand/Float32 972750 ns 844333.5 ns 1.15
private array/copyto!/gpu_to_gpu 495270.5 ns 614333 ns 0.81
private array/copyto!/cpu_to_gpu 716709 ns 739479 ns 0.97
private array/copyto!/gpu_to_cpu 586500 ns 599208 ns 0.98
private array/accumulate/1d 1439437 ns 1447750.5 ns 0.99
private array/accumulate/2d 1469541 ns 1496375 ns 0.98
private array/iteration/findall/int 2276896 ns 2263917 ns 1.01
private array/iteration/findall/bool 2040521 ns 1989875 ns 1.03
private array/iteration/findfirst/int 1683145.5 ns 1678000 ns 1.00
private array/iteration/findfirst/bool 1650417 ns 1663625 ns 0.99
private array/iteration/scalar 2420833.5 ns 2393834 ns 1.01
private array/iteration/logical 3427833 ns 3431520.5 ns 1.00
private array/iteration/findmin/1d 1776916 ns 1794125 ns 0.99
private array/iteration/findmin/2d 1374958 ns 1403416 ns 0.98
private array/reductions/reduce/1d 780312.5 ns 805792 ns 0.97
private array/reductions/reduce/2d 697334 ns 704146 ns 0.99
private array/reductions/mapreduce/1d 822541 ns 815812.5 ns 1.01
private array/reductions/mapreduce/2d 700937.5 ns 716666.5 ns 0.98
private array/permutedims/4d 932979 ns 943959 ns 0.99
private array/permutedims/2d 931250 ns 938875 ns 0.99
private array/permutedims/3d 1003917 ns 1005416.5 ns 1.00
private array/copy 844042 ns 862875 ns 0.98
latency/precompile 4418410750 ns 4407793041 ns 1.00
latency/ttfp 6886705542 ns 6915521687.5 ns 1.00
latency/import 727863562.5 ns 726643917 ns 1.00
integration/metaldevrt 743145.5 ns 749270.5 ns 0.99
integration/byval/slices=1 1622792 ns 1557959 ns 1.04
integration/byval/slices=3 8845459 ns 8832020.5 ns 1.00
integration/byval/reference 1521000 ns 1611291 ns 0.94
integration/byval/slices=2 2574417 ns 2583750 ns 1.00
kernel/indexing 462666.5 ns 476584 ns 0.97
kernel/indexing_checked 447020.5 ns 441500 ns 1.01
kernel/launch 11833.5 ns 10875 ns 1.09
metal/synchronization/stream 19000 ns 19208 ns 0.99
metal/synchronization/context 19667 ns 19750 ns 1.00
shared array/construct 24059.083333333336 ns 23756.916666666664 ns 1.01
shared array/broadcast 452333 ns 469584 ns 0.96
shared array/random/randn/Float32 1017208 ns 1020166 ns 1.00
shared array/random/randn!/Float32 634917 ns 634458 ns 1.00
shared array/random/rand!/Int64 571042 ns 572000 ns 1.00
shared array/random/rand!/Float32 590354.5 ns 593208.5 ns 1.00
shared array/random/rand/Int64 836625 ns 742792 ns 1.13
shared array/random/rand/Float32 785500 ns 898812.5 ns 0.87
shared array/copyto!/gpu_to_gpu 636208 ns 659667 ns 0.96
shared array/copyto!/cpu_to_gpu 91875 ns 94458 ns 0.97
shared array/copyto!/gpu_to_cpu 83000 ns 84333 ns 0.98
shared array/accumulate/1d 1435333 ns 1418250 ns 1.01
shared array/accumulate/2d 1474417 ns 1500167 ns 0.98
shared array/iteration/findall/int 1962084 ns 1939666 ns 1.01
shared array/iteration/findall/bool 1775916 ns 1746333 ns 1.02
shared array/iteration/findfirst/int 1414125 ns 1413458 ns 1.00
shared array/iteration/findfirst/bool 1381500 ns 1374750 ns 1.00
shared array/iteration/scalar 188166 ns 189167 ns 0.99
shared array/iteration/logical 3196479 ns 3212770.5 ns 0.99
shared array/iteration/findmin/1d 1463000.5 ns 1481709 ns 0.99
shared array/iteration/findmin/2d 1376270.5 ns 1379250 ns 1.00
shared array/reductions/reduce/1d 660729.5 ns 659583 ns 1.00
shared array/reductions/reduce/2d 693917 ns 706354 ns 0.98
shared array/reductions/mapreduce/1d 685959 ns 620667 ns 1.11
shared array/reductions/mapreduce/2d 699375 ns 704958.5 ns 0.99
shared array/permutedims/4d 930562.5 ns 963438 ns 0.97
shared array/permutedims/2d 935938 ns 939020.5 ns 1.00
shared array/permutedims/3d 1020375 ns 1003520.5 ns 1.02
shared array/copy 801458 ns 880541 ns 0.91

This comment was automatically generated by workflow using github-action-benchmark.

@maleadt maleadt merged commit da83511 into main Oct 4, 2024
2 checks passed
@maleadt maleadt deleted the nonightly branch October 4, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants