Minimal changes to jacobian in calculus.jl to allow for nonsquare Jacobians #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh and this resolves #371 |
lbenet
reviewed
Oct 17, 2024
src/calculus.jl
Outdated
|
|
||
| @inbounds for comp = 1:numVars | ||
| @inbounds for comp = 1:length(vf) |
There was a problem hiding this comment.
I think the following is recommended (it should have been changed before, but ...):
Suggested change
| @inbounds for comp = 1:length(vf) | |
| @inbounds for comp in eachindex(vf) |
src/calculus.jl
Outdated
|
|
||
| for comp = 1:numVars | ||
| for comp = 1:length(vf) |
src/calculus.jl
Outdated
| for comp2 = 1:numVars | ||
| for comp1 = 1:numVars | ||
| for comp1 = 1:length(vf) |
src/calculus.jl
Outdated
| for comp = 1:numVars | ||
| @inbounds for nv = 1:numVars | ||
| @inbounds for nv = 1:length(vf) |
|
All changes implemented now |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I enabled the CI workflow on my clone and things seemed OK, I hope there are some tests being run there becase I did not run any checks/tests manually :D