Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scalar->vector gradients #160

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ArnoStrouwen
Copy link
Contributor

@ArnoStrouwen ArnoStrouwen commented Nov 13, 2022

This is a breaking change.
Should the function be kept around but call jacobian under the hood, or do we remove it entirely?
Upstream tgrad depends on this, so needs to be nicely deprecated.

@ArnoStrouwen ArnoStrouwen marked this pull request as draft November 14, 2022 23:58
@ChrisRackauckas
Copy link
Member

Should we fold this into derivative!?

@ArnoStrouwen
Copy link
Contributor Author

I was thinking the same, because that is what ForwardDiff does,
but then the issue is that the derivative of a vector already has the meaning of taking the derivative of a scalar -> scalar function at each point in the vector, so adding scalar->vector functions will mess up the dispatch.
Maybe rename that multipoint functionality to FiniteDiff.finite_difference_derivatives with an s?

@ChrisRackauckas
Copy link
Member

Sounds fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants