Disable + and - rules on mixed numeric types #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is that constant tension in ChainRules between wanting to implement very general rules,
but not being sure you can rely on them to work for types that you can't trust to follow your epxectations.
This is the companion to JuliaDiff/Diffractor.jl#272
The version of this I have seen in the wild is calling Diffractor forwards mode over ForwardDiff,
and then getting
-(::Dual, Float64)which is defined, but this can result in-(::Tangent{<:Dual}, Float64)which is not defined.I am not convinced this is the best point to chose.
I think it might be argued that Diffractor's handling of
Dualis aberant,and it should be constructing either a Tangent which is a
Dualor it should be
@opt_out frule(::typeof(-), ::Dual, Float64)