Disallow mixing offset and non-offset axes in conv input
#586
+32
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #586 +/- ##
=======================================
Coverage 97.84% 97.84%
=======================================
Files 19 19
Lines 3249 3254 +5
=======================================
+ Hits 3179 3184 +5
Misses 70 70 ☔ View full report in Codecov by Sentry. |
wheeheee
reviewed
Nov 14, 2024
martinholters
force-pushed
the
mh/disallow-mixed-axes-conv
branch
from
97e6c31
to
4c19923
Compare
martinholters
commented
Nov 15, 2024
| @test_throws ArgumentError conv!(zeros(6), offset_arr, 1:3) # output needs to be OA, too | ||
| @test_throws ArgumentError conv!(OffsetVector{Int}(undef, 1:6), 1:4, 1:3) # output mustn't be OA | ||
|
|
||
| @test conv(fa, fill(true)) == conv(fill(true), fa) == fa | ||
| @test_broken conv(offset_arr_f, fill(true)) == conv(fill(true), offset_arr_f) == offset_arr_f |
There was a problem hiding this comment.
As fill(true) doesn't have any axes, this should arguably work. However, conv currently first brings all arguments to the same dimensionality, turning fill(true) into [true] here, and the axis compatibility check then says no. Fixing that is probably not important and certainly beyond the scope of this PR, but I thought leaving a @test_broken as a reminder might be in order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to #583, but doesn't fix it. Rather, it explicitly throws an error for any input where we're not quite sure what it should do. That would leave us the opportunity to make a more informed choice later when (and if) concrete use cases for mixed offset/non-offset inputs are reported.