Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow different argument eltypes for filt_stepstate (fix #573) #574

Merged
merged 8 commits into from
Oct 29, 2024
Merged

Allow different argument eltypes for filt_stepstate (fix #573) #574

merged 8 commits into from
Oct 29, 2024

Commits on Oct 29, 2024

  1. Relax filt_stepstate argument types (fix #573)

    @wheeheee
    wheeheee committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4ebf264 View commit details
    Browse the repository at this point in the history

  2. set maximum pad_length for iir_filtfilt

    @wheeheee
    wheeheee committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    b446d20 View commit details
    Browse the repository at this point in the history

  3. add tests

    @wheeheee
    wheeheee committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    4451eb0 View commit details
    Browse the repository at this point in the history

  4. directly use _filt_iir! 

    avoids unnecessary allocations esp. if x has >1 column
    @wheeheee
    wheeheee committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    72ce4e7 View commit details
    Browse the repository at this point in the history

  5. Document filtfilt(::AbstractVector...)

    @wheeheee
    wheeheee committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    c34cd43 View commit details
    Browse the repository at this point in the history

  6. try changing tests

    @wheeheee
    wheeheee committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    7c1a7cf View commit details
    Browse the repository at this point in the history

  7. fix test?

    @wheeheee
    wheeheee committed Oct 29, 2024
    Configuration menu
    Copy the full SHA
    cb7c3c5 View commit details
    Browse the repository at this point in the history

  8. Apply suggestions from code review 

    Co-authored-by: Martin Holters <[email protected]>
    @wheeheee @martinholters
    wheeheee and martinholters authored Oct 29, 2024
    Configuration menu
    Copy the full SHA
    57560e0 View commit details
    Browse the repository at this point in the history