extend lpc to complex inputs, other fixes
#517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #517 +/- ##
==========================================
+ Coverage 97.49% 97.56% +0.06%
==========================================
Files 18 18
Lines 3078 3121 +43
==========================================
+ Hits 3001 3045 +44
+ Misses 77 76 -1 ☔ View full report in Codecov by Sentry. |
- use rev_buf to eliminate allocs as much as possible - changed multiple assignment so that `@views` macro can be used on outer loop
- taking reference from PR 171 - separate `levinson` and `arburg` from `lpc` and export - reflection coefficients - `p::Integer`
- not sure if arburg handles complex arguments, but just in case.
- add test for complex - error for levinson is weirdly high - test errors more often than original, cannot figure out why
extra keyword argument for scaling in xcorr, fixes large prediction_error in levinson
1.0 doesn't support `CartesianIndices` with `StepRange`?
Co-authored-by: Martin Holters <[email protected]>
|
Didn't realize |
- removed redundant type parameters from drafting - add ! to mark possibly mutating function - note to write an autocorr function
martinholters
approved these changes
Feb 8, 2024
Could you expand on that? |
_normalize!(x::AbstractArray{<:Integer}, sz::Int) = (x ./ sz)I was referring to this, which is needed because an array of integers can't be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
levinsonby scalinglevinsonnow has original O(n) space complexityarburgandlevinsoncan now handle complex inputs