Update lpc.jl #512
Closed
Update lpc.jl #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also referenced PR#171. |
- eachindex stuff - `== nothing` to `=== nothing` - npairs = max(nz, np)
- use rev_buf to eliminate allocs as much as possible - changed multiple assignment so that `@views` macro can be used on outer loop
- `eachindex` to make sure `s` and `win` have compatible indices - `ArraySplit` for non 1-based arrays - chained comparisons coz they look pretty - more informative errors
- taking reference from PR 171 - separate `levinson` and `arburg` from `lpc` and export - reflection coefficients - `p::Integer`
- not sure if arburg handles complex arguments, but just in case.
- add test for complex - error for levinson is weirdly high - test errors more often than original, cannot figure out why
extra keyword argument for scaling in xcorr, fixes large prediction_error in levinson
fix incorrect usage of argmin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.