Add newline strip to prints prettily tests, tests pass now #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #101 |
|
@ssfrr can you approve? |
|
Looks like there were some issues with older versions of actions being used. Just updated the Tests workflow, retry please! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #103 +/- ##
==========================================
+ Coverage 76.20% 77.24% +1.04%
==========================================
Files 6 6
Lines 437 457 +20
==========================================
+ Hits 333 353 +20
Misses 104 104 ☔ View full report in Codecov by Sentry. |
|
Pretty sure x86 was being used for setup-julia, which doesn't work for macOS with older Julia versions, hopefully that's the last fix needed |
|
merged. thanks for your perseverance and patience! |
|
Thank you! Yep, no problem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing a pull request!
Please be aware that we are a loose team of volunteers so patience is
necessary. Assistance handling other issues is very welcome. We value
all user contributions, no matter how minor they are. If we are slow to
review, either the pull request needs some benchmarking, tinkering,
convincing, etc. or more likely the reviewers are simply busy. In either
case, we ask for your understanding during the review process.
Again, thanks for contributing!
What does this implement/fix?
Explain your changes. Please be as descriptive as possible.
Reference issue
Example: Fixes #1234.
Additional information
Any additional information you think is important.