Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the library compatible with CUDAdrv and CuArrays. #40

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Making the library compatible with CUDAdrv and CuArrays. #40

wants to merge 3 commits into from

Conversation

pevnak
Copy link
Collaborator

@pevnak pevnak commented Nov 15, 2017

There are couple issues I do not know, how to address.

  1. Some functions have been restricted to upper triangular form due to the ambiguity caused by CuArray<:AbstractArray being true

  2. I have removed streams from copy!, as I have not seen them really used. The connected problem is that I have commented

   statuscheck(ccall( (:cusparseSetStream, libcusparse), cusparseStatus_t, (cusparseHandle_t, cudaStream_t), handle, streamId))
end
function cusparseGetStream(handle, streamId)
  statuscheck(ccall( (:cusparseGetStream, libcusparse), cusparseStatus_t, (cusparseHandle_t, Ptr{cudaStream_t}), handle, streamId))
end

in libcusparse.jl. I have no idea, what streams are used for.

  1. I had to add conversion to the pointer, as
Base.unsafe_convert(::Type{Ptr{T}}, a::CuArray{T}) where {T} = Base.unsafe_convert(Ptr{T}, a.ptr)
  1. I had disable the following test
@test device(x)   == -1

since device is not the defined for CuArray.

@MikeInnes
Copy link

@pevnak I don't know if anyone is really maintaining this repo; if you want I can get you commit access so you can merge this at will?

@pevnak
Copy link
Collaborator Author

pevnak commented Jun 8, 2018

Hi Mike, I would probably not mind to get a commit access. I hope that I will have time to get back to programming for CUDA and make this work. In my area data are sparse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants