Trying to Send an Emoji Using Its 'Short name' makes UI Unresponsive

[vencabot]

Describe the bug
As of the 12.0.0 update, when users try to send an emoji using the textual chat box, the message will not send and the box's UI will become unresponsive, requiring a page refresh.

To Reproduce
Steps to reproduce the behavior:

1. Go to a video / Live that has chat enabled.
2. Manually enter an emoji's short name into the text box.
3. Attempt to send the message.
4. When the message fails to send, try to send the message with the 'send' button, which won't work, either.

Expected behavior
The message should send to the chat and the Short name should be replaced with the emoji graphic.

Screenshots
Footage of what the bug looks like:
https://tube.vencabot.com/w/d5CwUncRzNxCXpMKMXMjKq

In this video, 'fourtlDuck' is the shortname of an emoji. Sending any other text works fine, but when I try to send an emoji using its shortname, the UI freezes.

Server (please complete the following information):

• OS version [e.g. Debian 10, ...]: Ubuntu 22.04.5 LTS
• Peertube version: 6.3.3
• Peertube installation type [e.g. standard, docker, ...]: standard
• peertube-plugin-livechat version: 12.0.0

Desktop (please complete the following information):
Brought to my attention by several views, but my system:
OS: Windows 10
Browser: LibeWolf 131.0.3-1

Additional context
I greatly appreciate the work that you put into making this plug-in as good as it can be. Without it, I wouldn't be able to host my stream on PeerTube, which I've been enjoying immensely. Thank you!

[JohnXLivingston]

I know this bug. But i thought it was fixed :/

[JohnXLivingston]

Fix was there: https://github.com/conversejs/converse.js/pull/3501/files
It is in the plugin's code. So i don't understand how this bug has come again.

[vencabot]

Fix was there: https://github.com/conversejs/converse.js/pull/3501/files It is in the plugin's code. So i don't understand how this bug has come again.

Interesting. I'll try it with an emoji that is all-lowercase the next time I can get the plugin installed.

[JohnXLivingston]

This is clearly an uppercase issue.
I can reproduce this bug on my instance: just try to use ":John:" instead of ":john:".

On your instance, using "fourtlduck" should work.

I have to check the code again, maybe i missed a bug last time.

[JohnXLivingston]

I think my fix was not enough: if fixes emoji that are defined with uppercase...
But here, you are calling an emoji defined in lowercase, with an uppercase in the text message.

I'll check if i'm right.

[JohnXLivingston]

Good catch. I found other bugs.
Fix is here: conversejs/converse.js#3560

I will release a 12.0.1 version of the livechat.

[JohnXLivingston]

@vencabot , once you updated to v12.0.1, let me know if you have any trouble with emojis.

You can re-open this issue if needed (maybe some ConverseJS community members will subscribe to this issue, to have your feedbacks).

For the record, here is the change i made: now, custom emojis are case sensitive. If you configured ":AbC", you must type ":AbC", not ":abc". The emoji search and autocomplete remains case insensitive.

[vencabot]

I think this solution sounds very sensible. Once I'm able to reinstall the plugin, I'll definitely test this and I'll report back here. Thank you!

[vencabot]

Now that I'm able to install 12.0.1, I see that I'm not having this issue any more, or any of the issues that I was having after I upgraded to 12.0.0. I greatly appreciate you taking the time to talk through this with me and for graciously helping me get everything set up. All appears well, for now!