Chat History Loading is Unreliable

[vencabot]

Describe the bug
As of the 12.0.0 update, when I reload the chat room, the chat history often doesn't load. Sometimes it does, though, and it seems random.

To Reproduce
Steps to reproduce the behavior:

1. Set your chat history to never expire in the plugin settings.
2. Go to a video / Live that has chat enabled.
3. Send a few messages to the chat.
4. Close the tab and then visit the video again. Your previous messages may be missing.

Expected behavior
Because the chat history is set to never expire, the chat history should load any time a user connects to the chat.

Screenshots
Footage of what the bug looks like:
https://tube.vencabot.com/w/uAcRQDzT3QRwsjmyxw5oZG

Before recording this video, I was able to reproduce the bug many times. Sometimes, a couple of my messages from the previous cycle would be visible, but not all of them. During the recording of this video was the first time that, after reloading, the entire chat history reappeared. I tried and couldn't make the chat history vanish again while recording, but you can see at the start of the video that the chat's history is empty -- and then, when I reload, the chat history is totally populated.

Server (please complete the following information):

• OS version [e.g. Debian 10, ...]: Ubuntu 22.04.5 LTS
• Peertube version: 6.3.3
• Peertube installation type [e.g. standard, docker, ...]: standard
• peertube-plugin-livechat version: 12.0.0

Desktop (please complete the following information):
Brought to my attention by several views, but my system:
OS: Windows 10
Browser: LibeWolf 131.0.3-1

Additional context
Thank you for even considering looking into this and other issues. I'm sure that you must be very busy both with peertube-plugin-livechat and with other aspects of your life. Your graciousness brings goodness into my life and the lives of countless others, I'm sure! Have a good day.

[JohnXLivingston]

It could be related to the bug with uppercase in emoji names (#618): if there are such emoji in the chat history, it could throw an error that prevent the rendering of messages.

Are there any error in your browser console? (F12 to open)

Your graciousness brings goodness into my life and the lives of countless others, I'm sure! Have a good day.

Oh, that's so sweet! Thank you :)

[vencabot]

I also considered this as a possibility after our chat last night: that maybe the chat wasn't loading correctly because of an emoji in the chat history, and once I'd sent enough test messages those emoji got pushed out of range of being loaded, which is why it seemed to work. I'll do some tests again once I can re-install the plugin.

[JohnXLivingston]

I also considered this as a possibility after our chat last night: that maybe the chat wasn't loading correctly because of an emoji in the chat history, and once I'd sent enough test messages those emoji got pushed out of range of being loaded, which is why it seemed to work. I'll do some tests again once I can re-install the plugin.

Exactly.

v12.0.1 should fix.

I found the bug for the package catalog:
https://framagit.org/framasoft/peertube/plugin-index/-/issues/2

I'll propose a fix to framasoft. In the meantime, they fixed the database by hand. You should be able to install the plugin now.

[vencabot]

I'll propose a fix to framasoft. In the meantime, they fixed the database by hand. You should be able to install the plugin now.

I'm finally falling asleep myself, but I did manage to re-install the plug-in, now, without issue. I can't test as rigorously as I would like, but:

• the emoji picker is working normally
• the chat history is working normally
• sending emoji with their short-names is working normally

If I have any issues in the future, I'll report them, but I don't expect that I will. Everything seems fixed! Thank you so much for your patience and for addressing these issues.

[JohnXLivingston]

If I have any issues in the future, I'll report them, but I don't expect that I will. Everything seems fixed! Thank you so much for your patience and for addressing these issues.

I think all issues had the same origin.
Even the emoji picker not displaying: maybe you had some custom emoji with uppercase in their name... And maybe it triggered the same bug.
So, i will close all issues. Re-open them if you have any trouble.