Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix erroneous relative path #258

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jonatan-hanssen
Copy link

openood/evaluation_api/evaluator.py uses filepath.split('/') on the absolute path of its own location, but this removes the first /, making the path relative instead of absolute. This means that openood/evaluation_api/postprocessor.py line 76 will always fail, because it is looking at $(pwd)/abolute/path/to/config as opposed to just the absolute path. It will then do a urllib.request and get the config file from github and create directories mirroring the absolute path in the current working directory. If you clone the repo in your home directory and create an Evaluator instance while in the repo, Evaluator will create the following directories and file: /home/user/OpenOOD/home/user/OpenOOD/configs/postprocessors/react.yml as opposed to getting react.yml from /home/user/OpenOOD/configs/postprocessors.

Signed-off-by: Jonatan Hanssen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant