Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install curl before trying to install docker #345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

install curl before trying to install docker #345

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/server_manager/install_scripts/install_server.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,24 @@ function log_for_sentry() {
fi
}

# Check to see curl is installed.
function verify_curl_installed() {
if command_exists curl; then
return 0
fi
log_error "CURL NOT INSTALLED"
echo -n
if ! confirm "> Would you like to install Curl? This will run 'apt update && apt upgrade && apt install curl | sh'. [Y/n] "; then
exit 0
fi
if ! run_step "Installing Curl" install_curl; then
log_error "Curl installation failed."
exit 1
fi
echo -n "> Verifying Curl installation................ "
command_exists curl
}

# Check to see if docker is installed.
function verify_docker_installed() {
if command_exists docker; then
Expand Down Expand Up @@ -118,6 +136,9 @@ function verify_docker_running() {
fi
}

function install_curl() {
apt update && apt upgrade && apt install curl | sh > /dev/null 2>&1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to pipe to sh?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need apt upgrade?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it is because it will install an outdated version of curl otherwise.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apt update gets the version info. apt upgrade will attempt to upgrade all of the installed packages. Definitely not needed to get the latest version of curl.

}
function install_docker() {
curl -sS https://get.docker.com/ | sh > /dev/null 2>&1
}
Expand Down