Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: switch to advanced setup for code scanning #2316

Merged
merged 4 commits into from
Jan 3, 2025
Merged

Conversation

jyyi1
Copy link
Contributor

@jyyi1 jyyi1 commented Jan 2, 2025

This PR addresses the inconsistent Node version issue in standard code scanning by migrating to advanced code scanning according to the official GitHub document.

I also added C# and Java to the code scanning configuration. Swift is not enabled due to errors, and we can investigate this in the future, as Swift was not enabled in the original configuration either.

Original Configuration

@jyyi1 jyyi1 requested a review from a team as a code owner January 2, 2025 20:57
@github-actions github-actions bot added the size/S label Jan 2, 2025
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@jyyi1 jyyi1 changed the title ci(fix): switch to advanced setup for code scanning ci: switch to advanced setup for code scanning Jan 2, 2025
@jyyi1 jyyi1 requested review from fortuna and sbruens January 2, 2025 22:21
@jyyi1
Copy link
Contributor Author

jyyi1 commented Jan 2, 2025

Manager test is fixed in #2317

Copy link
Collaborator

@fortuna fortuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the build!

build-mode: none # This mode only analyzes Java. Set this to 'autobuild' or 'manual' to analyze Kotlin too.
- language: javascript-typescript
build-mode: none
# TODO: swift is disabled due to the following error:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we need the manual mode listed below to build Tun2socks first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, but I'm wondering why Java is working.

@jyyi1 jyyi1 merged commit c7e829c into master Jan 3, 2025
27 checks passed
@jyyi1 jyyi1 deleted the junyi-codescan-fix branch January 3, 2025 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants