Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(client): update server card to use @material/web #2133

Merged
merged 3 commits into from
Aug 20, 2024

Conversation

daniellacosse
Copy link
Contributor

@daniellacosse daniellacosse commented Aug 20, 2024

Taking a short detour to port the server card to material web so I can move the server rename dialog into the server view folder

@daniellacosse daniellacosse marked this pull request as ready for review August 20, 2024 12:57
@daniellacosse daniellacosse requested a review from a team as a code owner August 20, 2024 12:57
@daniellacosse daniellacosse requested a review from sbruens August 20, 2024 12:58
server-row-card {
margin: 0 auto 8px auto;
height: 130px;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this anymore! the height of the row cards adapts to the inner text

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen.Recording.2024-08-20.at.9.02.26.AM.mov

@daniellacosse daniellacosse merged commit 7295b73 into master Aug 20, 2024
25 checks passed
@daniellacosse daniellacosse deleted the daniellcosse/lit/server_view_detour branch August 20, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants