chore(client): port about and language views to lit #2122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to split this into two prs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the about and language views to lit but doesn't add them to the app itself yet. You can see them in the storybook. I'm delaying moving them to the app because I'm saving the app-root migration for the end.
TODO: upon further reflection, I think we should add
@material/weband@lit/localizeto the equation in this process. We can always catch the other components up at the end.Note that I know we want to migrate to
@material/websince@material/mwc-*is now deprecated - but considering our current investment in mwc with the contact view I'm inclined to do that later in the interest of consistency. Thoughts?I also need to do move us to lit localization as well https://lit.dev/docs/localization/overview/ - I could do that now or later, too.