Use convertToZeroTerminatedString on both wasm and js targets #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eymar
reviewed
Aug 6, 2024
|
|
||
| val utf8 = string.encodeToByteArray() // encodeToByteArray encodes to utf8 | ||
| // TODO Remove array copy, use `skString(data, length)` instead of `skString(data)` | ||
| return utf8.copyOf(utf8.size + 1) |
There was a problem hiding this comment.
Is it guaranteed that the 1 extra byte would be \0? Or maybe we better set its value explicitly?
There was a problem hiding this comment.
it's guaranteed by spec for ByteArray.copyOf from Kotlin stdlib
eymar
reviewed
Aug 6, 2024
| @@ -23,6 +23,12 @@ class ManagedStringTest { | |||
| assertEquals("你好", s3) | |||
| } | |||
|
|
|||
| @Test | |||
| fun emptyStringTest() { | |||
There was a problem hiding this comment.
What do you think about adding a few more simple tests with intiially empty strings:
s.insert(0, ""), s.append("").
Also I'm wondering what is going to happen if we call insert with an index out of bounds. Also remove with an index out of bounds.
eymar
approved these changes
Aug 6, 2024
MatkovIvan
reviewed
Aug 6, 2024
| /** | ||
| * Converts String to zero-terminated utf-8 byte array. | ||
| */ | ||
| internal fun convertToZeroTerminatedString(string: String): ByteArray { |
There was a problem hiding this comment.
The name is confusing - I thought that toInterop is recursive. It converts to ByteArray, not string
Also better to include "utf8" in some form to the name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is supposed to be fix for #967
The idea is pass strings as (utf8) byte arrays directly through the border
just like we do it on native