Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Adding Android Builds #4

Closed
wants to merge 5 commits into from

Conversation

Danielku15
Copy link
Contributor

In preparation for having a Skija on Android (JetBrains/skija#101) this PR adds Android builds to the toolchain. This PR includes:

  • An Android build matrix to compile Skia with NDK
  • Unifying a bit the argument parsing of the python scripts
  • A new input for GitHub Actions to Skip any release related steps (allows better building in forks and trying out things without actually publishing a release)

I couldn't check the binaries yet so I trust that the Skia script handles the compilation well. Next step will be to extend Skija to target Android.

See latest compilation here:
https://github.com/Danielku15/skia-build/actions/runs/680600460

@nathanieloliveira
Copy link

I can't belive I spent the last day working on basically the same thing 😂. I should have checked the open PRs section.

I'm hoping this gets merged. After implementing this myself, I've arrived at essentially the same implementation as you. My only doubt is: I can't point out when you download or install the Android NDK...
Should we have a way to specify which version of the NDK to use?
Thanks

@Danielku15
Copy link
Contributor Author

@nathanieloliveira NDK comes pre-shipped with the linux images of GitHub Actions: https://github.com/actions/virtual-environments/blob/ubuntu16/20210318.0/images/linux/Ubuntu1604-README.md

Currently by default it is pointing to 21.4.7075529. GitHub had some issues with the rollout of r22 in GitHub Actions.
actions/runner-images#2420

@nathanieloliveira
Copy link

@nathanieloliveira NDK comes pre-shipped with the linux images of GitHub Actions: https://github.com/actions/virtual-environments/blob/ubuntu16/20210318.0/images/linux/Ubuntu1604-README.md

Currently by default it is pointing to 21.4.7075529. GitHub had some issues with the rollout of r22 in GitHub Actions.
actions/virtual-environments#2420

Interesting... In my attempt, I was downloading NDK-r22 from google repos and using ubuntu latest image.

@tonsky
Copy link
Contributor

tonsky commented Mar 24, 2021

Thank you! I’ll take a look soon

@tonsky
Copy link
Contributor

tonsky commented Mar 26, 2021

Seems to work! https://github.com/JetBrains/skia-build/actions/runs/690480166. Merged as efb641a. Thank you!

@tonsky tonsky closed this Mar 26, 2021
@Danielku15 Danielku15 deleted the feature/android branch March 26, 2021 17:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants