Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GeneratedResClassSpec.kt #5190

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

mgroth0
Copy link
Contributor

@mgroth0 mgroth0 commented Dec 18, 2024

Suppress "redundant visibility modifier" diagnostics so Res is compatible with -Werror, -Wextra, and IntelliJ inspections

Fixes [CMP-7193]

Testing

A test may be added for this which confirms that the Res class compiles with -Werror and -Wextra.

Release Notes

Section: - Fixes
Subsection: - Resources
Description: Generate Suppress annotation on generated Res class for redundant visibility modifier diagnostics

Suppress "redundant visibility modifier" diagnostics so Res is compatible with `-Werror`, `-Wextra`, and IntelliJ inspections
@MatkovIvan MatkovIvan requested a review from terrakok December 18, 2024 16:06
@terrakok
Copy link
Member

Test runs will be red because you are supposed to update tests as well

@mgroth0
Copy link
Contributor Author

mgroth0 commented Dec 18, 2024

I cannot figure out these test failures. The test tasks fail locally on my computer because of the different operating systems. For GitHub actions, I don't know how to see the test report and cannot find the exception in the output. For example, https://github.com/JetBrains/compose-multiplatform/actions/runs/12399471669/job/34614451470?pr=5190 says build was failed with an exception. But what exception? I cannot find it in the logs, I think it might have not been printed.

@terrakok
Copy link
Member

Download a zip archive with test reports here: https://github.com/JetBrains/compose-multiplatform/actions/runs/12399471669?pr=5190

@mgroth0
Copy link
Contributor Author

mgroth0 commented Dec 20, 2024

Can I please have a little help again? I looked at the most recent reports, but cannot find the cause of the test error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants