Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gradle] Add dependency shortcuts for Compose Material3 adaptive components #5121

Closed
wants to merge 1 commit into from

Conversation

terrakok
Copy link
Member

Release Notes

Features - Gradle Plugin

  • New dependency shortcuts: compose.material3Adaptive, compose.material3AdaptiveLayout, compose.material3AdaptiveNavigation

@terrakok terrakok requested a review from igordmn August 20, 2024 09:33
@terrakok terrakok force-pushed the k.tskh/adaptive-deps branch from 3969c1c to 43556bb Compare August 21, 2024 07:49

internal val composeVersion get() = ComposeBuildConfig.composeVersion
private const val material3AdaptiveVersion = "1.0.0-alpha01"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require updating it every time we build a new version.

I suggest to not merge it, considering that:

  1. it complicates the release process, as there are too many implicit things we need to keep in mind
  2. adaptive will probably will be aligned with material3 when it is released
  3. if we decide to do it anyway, we need to automate it on CI
  4. we are thinking about moving from DSL versioning to libs.version.toml
  5. we have other non-aligned libs like navigation/lifecycle, we mention versions for them in the changelog

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we decide to do it anyway, we need to automate it on CI

We can read it from compose-multiplatform-core repo after CMP-5665 Change versioning (get rid of 0.0.0 and 1.7.0-devXXX)

@terrakok
Copy link
Member Author

OK. I close the issue until we decide the way how to provide the versions.
Current way is:

dependencies {
  implementation("org.jetbrains.compose.material3.adaptive:adaptive:1.0.0-alpha01")
  implementation("org.jetbrains.compose.material3.adaptive:adaptive-layout:1.0.0-alpha01")
  implementation("org.jetbrains.compose.material3.adaptive:adaptive-navigation:1.0.0-alpha01")
}

@terrakok terrakok closed this Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants