-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file associations support documentation #5054
Add file associations support documentation #5054
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, will send to copyediting after approve from Zamulla
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most importantly I think we would benefits from comments in the code, other suggestions are phrasing polish.
Co-authored-by: Aleksey Zamulla <[email protected]>
Co-authored-by: Aleksey Zamulla <[email protected]>
Co-authored-by: Aleksey Zamulla <[email protected]>
Co-authored-by: Aleksey Zamulla <[email protected]>
Co-authored-by: Aleksey Zamulla <[email protected]>
Co-authored-by: Aleksey Zamulla <[email protected]>
Co-authored-by: Aleksey Zamulla <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good 👍
Docs for file associations support (#4957) which fixes #773.