[gradle] New Compose Compiler gradle plugin checks. #4604
Conversation
| } | ||
| } | ||
|
|
||
| internal const val newCompilerIsAvailableVersion = "2.0.0-RC1" |
There was a problem hiding this comment.
| internal const val newCompilerIsAvailableVersion = "2.0.0-RC1" | |
| internal const val newCompilerIsAvailableVersion = "2.0.0" |
The 2.0.0-RC1 Compose Compiler isn't suitable for Compose Multiplatform.
If we'll have some Kotlin RC that supports it, we can downgrade this version later.
@eymar, please, confirm
There was a problem hiding this comment.
Some thoughts:
- RC1 is the only version we can test this chnage at the moment.
- RC1 is okay for android+jvm projects where we can test this change.
But we should not force 1.6.10-beta01 users to apply a new compose-compiler-gradle plugin, because it doesn't support compose multiplatform yet.
Perhaps we don't merge this now, so it won't go into 1.6.10-beta01.
Before merging, we can update to RC2 (hopefully) or RC3 version here.
...-plugins/compose/src/main/kotlin/org/jetbrains/compose/ComposeCompilerKotlinSupportPlugin.kt
Outdated
Show resolved
Hide resolved
gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/ComposeExtension.kt
Show resolved
Hide resolved
gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/internal/Version.kt
Show resolved
Hide resolved
...-plugins/compose/src/main/kotlin/org/jetbrains/compose/ComposeCompilerKotlinSupportPlugin.kt
Outdated
Show resolved
Hide resolved
…ied. To throw a configuration error if it's not, and to fail the build
terrakok
force-pushed
the
k.tskh/new-comp-plugin
branch
from
0663b4d to
a99a95a
Compare
|
The error happens because there is no Kotlin 2.0.0-RC2 yet |
Is it only in tests? Can we disable them? We need to merge the PR before it will be available |
...-plugins/compose/src/main/kotlin/org/jetbrains/compose/ComposeCompilerKotlinSupportPlugin.kt
Outdated
Show resolved
Hide resolved
If KGP >= 2.0.0-RC1 new Compose gradle plugin has to be applied.
To throw a configuration error if it's not.