Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text style in mpp demo #996

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

MatkovIvan
Copy link
Member

Proposed Changes

After b4443bd (1.6.0 merge) lineHeight is explicitly specified in MaterialTheme. It makes incorrect usage of fontSize parameter alone. This behavior already exists in material3, so it's by design.
This PR fixes the incorrect usage in our demo app.

Testing

Test: run mpp > "FontFamilies" page

image

@MatkovIvan MatkovIvan requested a review from igordmn January 17, 2024 11:53
@MatkovIvan MatkovIvan merged commit 6a1e1df into jb-main Jan 17, 2024
6 checks passed
@MatkovIvan MatkovIvan deleted the ivan.matkov/fix-fontfamily-sample branch January 17, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants