CMP-7142: Encode and decode URL fragments for web navigation routing. #1738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update ensures URL fragments are properly encoded and decoded using `encodeURIComponent` and `decodeURIComponent`. It improves handling of special characters in navigation paths, preventing potential issues with URL interpretation. Relevant tests have been updated to reflect this change.
Schahen
reviewed
Dec 16, 2024
|
|
||
| private fun NavController.tryToNavigateToUrlFragment(localWindow: BrowserWindow) { | ||
| val route = localWindow.location.hash.substringAfter('#', "") | ||
| val route = decodeURIComponent(localWindow.location.hash.substringAfter('#', "")) |
There was a problem hiding this comment.
in theory if in all browsers hash is returned with # we can just remove first symbol but not a big deal
There was a problem hiding this comment.
why? I don't see benefits here. It is not faster
Schahen
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update ensures URL fragments are properly encoded and decoded using
encodeURIComponentanddecodeURIComponent. It improves handling of special characters in navigation paths, preventing potential issues with URL interpretation. Relevant tests have been updated to reflect this change.Fixes https://youtrack.jetbrains.com/issue/CMP-7142
Testing
Release Notes
Fixes - Navigation