Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type change from soft link to actual file to fix resource loading iss… #1049

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

mholtrop
Copy link
Collaborator

Simply fix: change soft linked files to the actual files.

@sarahgaiser
Copy link
Collaborator

sarahgaiser commented Sep 20, 2024

Hi Maurik, could you explain the issue again, briefly? I think I missed most of your explanation during the meeting...
I saw the description of iss_1048 this PR is fixing but could you explain again how you encountered this problem?

@mholtrop
Copy link
Collaborator Author

@sarahgaiser The issue is that if you have soft links (i.e. files that refer to other files, which you create with "ln -s old_name new_name") in your Java resources, then the reading of these files is not well defined, i.e. all bets are off when it will work and when not. It turns out that so far it has worked on Linux with the versions of Java we used, but the newer version of Java on my Mac, it does not work as expected.
The correct way to solve this is to not have links but make actual copies of the files (i.e. "cp old_name new_name"). There were only a few files that were links, and so I copied them instead of linked them.
I hope that explains it.

@sarahgaiser
Copy link
Collaborator

Note: I checked building this on my M1 mac and it worked fine.

@sarahgaiser sarahgaiser merged commit 9e9aa5d into master Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource files are not properly loaded in ClusterEnergyCorrection2021 or related classes.
3 participants