Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kd_forest rework #34

Merged
merged 5 commits into from
Sep 7, 2023
Merged

kd_forest rework #34

merged 5 commits into from
Sep 7, 2023

Conversation

Jaybro
Copy link
Owner

@Jaybro Jaybro commented Sep 7, 2023

This PR reworks the RKdTree to KdForest. Not only the name changed, but the following as well:

  • Applying a transformation that results in a random orthogonal base went from a quadratic to a linear time algorithm.
  • The KdTree defeatist search has been replaced by a priority search for improved speed and precision.
  • The KdForest is no longer dependent on an external library.
  • Reworked the mnist example into the kd_forest example.
    • Fix: tested against the incorrect ground truth filename.
    • The example now uses the SIFT dataset on top of the MNIST dataset.
  • Fix: added a missing include for std::reference_wrapper<>.
  • Increased version to v0.8.2.

@Jaybro
Renamed RKdTree to KdForest.
4f41141 
Dataset rotation from quadratic to linear time algorithm.
Removed dependency on Eigen3 for the KdForest and mnist example.
Fixed mnist example using the wrong ground truth filename.
@Jaybro
Reworked the MNIST example to include the SIFT dataset.
a001c0b 
Added support for reading the SIFT dataset to pico_toolshed.
Renamed the mnist example to kd_forest.
Documentation updated.
@Jaybro
KdTree defeatist search replaced with a priority search.
a723965 
Added the max_leaves_visited parameter for the KdForest.
KdForest example updated.
@Jaybro
Updated to std::tolower from <locale>.
9cb153a
@Jaybro
Added missing std::reference_wrapper<> include.
c05db63 
Simplified some CMake.
Updated version to v0.8.2.
@Jaybro Jaybro added bug Something isn't working enhancement New feature or request labels Sep 7, 2023
@Jaybro Jaybro self-assigned this Sep 7, 2023
@Jaybro Jaybro linked an issue Sep 7, 2023 that may be closed by this pull request
can not compile on Ubuntu18.04 gcc7.5 #32
Closed
@Jaybro Jaybro merged commit 46699e6 into master Sep 7, 2023
6 checks passed
@Jaybro Jaybro deleted the kd_forest branch September 7, 2023 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Jaybro Jaybro

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

can not compile on Ubuntu18.04 gcc7.5
1 participant
@Jaybro