feat: Add scrobble mode option #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdrxy
changed the title
|
Thanks for this! Will try to review in the next day or few. |
JasonPuglisi
approved these changes
Jul 23, 2024
Users can now choose between displaying the most recent scrobbled track or only the currently playing track.
|
Trying to get the build action to run on the fork, I'll force merge if I can't get it to work. |
JasonPuglisi
had a problem deploying
to
gcp-app-engine
GitHub Actions
Failure
|
Nice, seems to work with Deezer, too, which do not deliver a "now playing" API info when using their internal scrobbling option. I think the info line on the screen should rather say "hjbardenhagen was last listening to" in this case if possible? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now choose between displaying the most recent scrobbled track or only the currently playing track.
Addresses #149