Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance Kubernetes Readiness with gRPC Health Checks & Update Kind Cluster Setup #1479

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Enhance Kubernetes Readiness with gRPC Health Checks & Update Kind Cluster Setup #1479

wants to merge 8 commits into from
+230 −48

Conversation

AshishMahendra
Copy link
Collaborator

@AshishMahendra AshishMahendra commented Dec 4, 2024 •
edited
Loading

Description

Key Changes:

  • Integrate gRPC Health Checking Protocol:

    • Added grpc_health.v1.health service to server.py.
    • Configured Health Servicer to report SERVING status.

  • Update Kubernetes Readiness Probes:

    • Configured gRPC readiness probes on port 50051 in pod manifests.

  • Update README.md:

    • Added instructions for recreating the Kind cluster with specific port mappings.

  • Dependencies:

    • Added grpcio-health-checking to dockerfile.

  • Test Suite

    • Enhance mock_kubernetes_and_grpc to include readiness probe simulation.
      • Simulate pod lifecycle with Pending state transitioning to Running and Ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsninja marsninja marsninja approved these changes

Assignees

@marsninja marsninja

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AshishMahendra @marsninja