Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MEMORY]: Improve memory syncing #1449

Merged
merged 2 commits into from
Nov 26, 2024
Merged

[MEMORY]: Improve memory syncing #1449

merged 2 commits into from
Nov 26, 2024

Conversation

amadolid
Copy link
Collaborator

First trigger of memory sync can possibly load additional architypes if needed
Second trigger will handle it

@amadolid amadolid force-pushed the improvement/memory-sync branch from 69f1657 to 859e2d8 Compare November 18, 2024 10:19
ypkang
ypkang requested changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@ypkang ypkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a test case that covers this.

@ypkang ypkang merged commit 6340f74 into main Nov 26, 2024
3 checks passed
@ypkang ypkang deleted the improvement/memory-sync branch November 26, 2024 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypkang ypkang ypkang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amadolid @ypkang